YF-GoogleCodeBackups / masterpasswordtimeoutplus

Automatically exported from code.google.com/p/masterpasswordtimeoutplus
0 stars 0 forks source link

extensions.masterPasswordPlus.forceprompt doesn't allow to disable forced prompt for Session Manager #51

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
New extensions.masterPasswordPlus.forceprompt preference from Master Password+ 
1.21.1 aren't used for Session Manager:

chrome.manifest
overlay chrome://sessionmanager/content/session_prompt.xul                              chrome://mapap
lus/content/masterpasswordplusForcePromptOverlay.xul

Session Manager can encrypt session data, so, I think, any additional prompt 
aren't needed. And I want to disable this feature for Session Manager.

Original issue reported on code.google.com by infocatc...@gmail.com on 10 Mar 2013 at 7:21

GoogleCodeExporter commented 9 years ago
Ops, some leftovers...thanks. The bottom 3 lines in chrome.manifest should not 
be there...

Are you talking about session manager extension or built-in session manager?
The reason for forcibly show mp prompt for session manager (extension) window 
is when MP+ set to prompt on startup and in some situations session manager 
prompt shows before MP prompt.
Perhaps I could add additional parameter to enforce it only at startup.

Original comment by van...@gmail.com on 11 Mar 2013 at 12:52

GoogleCodeExporter commented 9 years ago
I'm talking about Session Manager extension.

I'm don't use "prompt on startup" (and this can be easily bypassed, if user can 
write into Firefox profile directory). So Session Manager's dialog shouldn't be 
handled at all in my case, I think.

Original comment by infocatc...@gmail.com on 11 Mar 2013 at 1:28

GoogleCodeExporter commented 9 years ago
It shouldn't unless Session Manager requires access to encrypted by master 
password data.

Original comment by van...@gmail.com on 12 Mar 2013 at 2:04

GoogleCodeExporter commented 9 years ago
Yes, but MP+ prompt is still here even if encryption are disabled in Session 
Manager options.

Original comment by infocatc...@gmail.com on 12 Mar 2013 at 3:49

GoogleCodeExporter commented 9 years ago
And you are sure that with MP+ disabled there is no master password prompt?

If MP+ is not set to ask for password on startup, then it shouldn't unless 
there is something else requires encrypted data (could be a web page or other 
extension), at which case it's not MP+ that asks for it.

A simple test can be done by disabling MP+ extension.

Original comment by van...@gmail.com on 12 Mar 2013 at 3:53

GoogleCodeExporter commented 9 years ago
Steps to reproduce:
0. New profile + Session Manager 0.7.9.6
1. Set master password
2. App Button – Session Manager – Save Session – press "Save Session" 
button (all works, no master password prompt)
3. Install Master Password+ 1.21.1
4. Set
Prompt – Block master password prompts: All
5. Session Manager – Save Session – master password prompt

Original comment by infocatc...@gmail.com on 12 Mar 2013 at 8:12

GoogleCodeExporter commented 9 years ago
(tested on Firefox 19.0.2)

Original comment by infocatc...@gmail.com on 12 Mar 2013 at 8:13

GoogleCodeExporter commented 9 years ago
Got it.

Thanks.

P.S.
when you hit "save" button or try load encrypted sessions it will ask you for 
password anyway.
Anyhow I've added more capabilities to forceprompt setting so each entry can be 
disabled without deleting entire entry and can accept additional parameters 
such as how to handle the window, weather force MP prompt regardless of status 
or only force it on startup when MP+ set to prompt on startup.
Will be available in next version.

Original comment by van...@gmail.com on 12 Mar 2013 at 10:56