YH-15 / pe

0 stars 0 forks source link

Changing JSON file data to illegal state cause error #4

Open YH-15 opened 1 year ago

YH-15 commented 1 year ago

Duplicate persons cannot be added to the system in the GUI, but it seems that there is a walkaround to do this by modifying raw data in the JSON file. In the below screenshots, it shows that if I change the raw data to contain a duplicate Name, then the app will be shown as blank upon reopening. [Alerting the user about this in the UG might be a good way to avoid this.]

nus-pe-bot commented 1 year ago

Team's Response

ID: 66 495 725 726 1237 1594 2442 have similar issues

It is indeed our oversight that we have forgotten to warn users not to tamper with the json file in the wrong way in our documentation. Users should be warned that any editing to the json should be done correctly or else they might encounter a wipe out of their stored data.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Modifying json file can result in user being in an invalid group

Since the tp has a Constraint-Human-Editable-File, I tried modifying the json file.

image.png

After modifying it, I was able to let Bernice Yu have tasks assigned to an invalid group.

image.png


[original: nus-cs2103-AY2223S1/pe-interim#1610] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

edits to the json file should be done accurately and correctly as per the requirements

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]