search

YHWong20 / pe

0 stars 0 forks source link

UML diagram format is not correct #11

Open YHWong20 opened 1 month ago

YHWong20 commented 1 month ago

image.png

A C symbol should not be present in the class diagram.

#-+ symbols to denote access modifiers are not present in the diagram.

soc-se-bot commented 3 weeks ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Visibilities of class diagrams are not compliant with course's notation

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

The above is taken from the course website, specifying that the visibility should either be +, -, # or ~.

image.png

In your class diagram, the visibilities are not any of the signs mentioned above.

Using the +, -, # or ~ will be much easier for any programmers to understand the visibilities, rather than just using the green and red boxes.

[original: nus-cs2113-AY2324S2/pe-interim#2180] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]