search

YIO-Remote / integration.spotify

🔌 Spotify Integration for YIO
GNU General Public License v3.0
2 stars 3 forks source link

Add songs to the play queue #16

Closed jadlers closed 4 years ago

jadlers commented 4 years ago

Hi,

This PR adds the "Add to queue" command to the list of commands for a single track. In order for this to function I also had to add the addToQueue extension to the media player entity in the YIO-Remote/remote-software repository. There's a PR open there as well: https://github.com/YIO-Remote/remote-software/pull/497

My first code related contribution and even though it's not a lot of code I'd highly appreciate feedback if there's something that could have been done better!

2020-08-11_16-12-33

jadlers commented 4 years ago

I've now also created a PR in the integrations.library repo. As you (@zehnm) pointed out on Discord I need to change the dependencies.cfg file to use the new branch. Is it possible to use my fork or only branches on the main repo are allowed?

zehnm commented 4 years ago

Is it possible to use my fork or only branches on the main repo are allowed?

The required PR of integrations.library is merged and a new release v0.5.1 has been created. If you pull in the latest integrations.library in your fork, you're good to go.

Required change for this PR: modify dependencies.cfg to include the new release

integrations.library: v0.5.1

Then the build will work and this PR can be merged 👍

jadlers commented 4 years ago

All done, thanks for the guidance throughout this PR @zehnm !