search

YIO-Remote / remote-software

💎 YIO Remote Software repository
GNU General Public License v3.0
164 stars 21 forks source link

Add `addToQueue` extension to mediaplayer entity #497

Closed jadlers closed 4 years ago

jadlers commented 4 years ago

This PR will add an addToQueue extension to the MediaPlayer entity.

There seems to be some work already done preparing for the feature of queuing songs. This PR is needed in order for my "add to queue" implementation for the Spotify integration to work. See that PR here: https://github.com/YIO-Remote/integration.spotify/pull/16

Is this the way it was intended to be used? It's my first contribution and would be glad for any feedback!

jadlers commented 4 years ago

When I started implementing the feature I came across these lines https://github.com/YIO-Remote/remote-software/blob/master/basic_ui/ContextMenu.qml#L122-L123. All I did in this PR is to implement the function called. I'm guessing something was planned for queuing since these lines where added 8 months ago by @martonborzak.

jadlers commented 4 years ago

Updated here as well, thanks again!