search

YIO-Remote / remote-software

💎 YIO Remote Software repository
GNU General Public License v3.0
164 stars 21 forks source link

Feature/custom buttons remote #504

Closed nikos1988 closed 3 years ago

nikos1988 commented 4 years ago

PR 3/3

martonborzak commented 4 years ago

@nikos1988 could you please write a brief description of what the PR does? Thanks!

nikos1988 commented 4 years ago

An icon font is used to store icons. It would be better to stick to that and expand it, rather than bringing in SVGs. I can help with this @nikos1988

Yes that would be nice

nikos1988 commented 4 years ago

@nikos1988 could you please write a brief description of what the PR does? Thanks!

The PR makes some changes to the remote entity and adds the possibility for integrations to add custom features (buttons) to entities. The idea was to be able to replicate all functions of a remote, e.g. AVR or TV where the supported features are just not enough.

The custom buttons are shown in an extra page on the swipeview of the remote entity. I also added a page for the colored function buttons. Furthermore i added icons for the transport feature buttons and did some minor cosmetic changes.

nikos1988 commented 4 years ago

I removed the unnecessary logging

zehnm commented 3 years ago

@nikos1988 what's the state of this PR? It's still in draft and hasn't seen activity in a while. Note: with the soon to be merged PR #522 there might be some changes required.

nikos1988 commented 3 years ago

@nikos1988 what's the state of this PR? It's still in draft and hasn't seen activity in a while. Note: with the soon to be merged PR #522 there might be some changes required.

Hi, i made some changes as Marton suggested. Actually i was waiting for a reply.

zehnm commented 3 years ago

Hi, i made some changes as Marton suggested. Actually i was waiting for a reply.

Ok, I'm changing it to "ready for review" so we can continue reviewing it.

nikos1988 commented 3 years ago

Okay, I just pushed an update

zehnm commented 3 years ago

Okay, I just pushed an update

Please update the dependencies.cfg and set integrations.library: v0.6.0 to fix the compile error

nikos1988 commented 3 years ago

Okay, I just pushed an update

Please update the dependencies.cfg and set integrations.library: v0.6.0 to fix the compile error

It is already on v0.6.0, isn't it?

zehnm commented 3 years ago

Okay, I just pushed an update

Please update the dependencies.cfg and set integrations.library: v0.6.0 to fix the compile error

It is already on v0.6.0, isn't it?

Nope, the build is failing because of missing definitions in integrations.library. The dependencies.cfg is also missing in this PR. Update your local file and include it in the PR. The PR must successfully compile for further review.

nikos1988 commented 3 years ago

Okay, I just pushed an update

Please update the dependencies.cfg and set integrations.library: v0.6.0 to fix the compile error

It is already on v0.6.0, isn't it?

Nope, the build is failing because of missing definitions in integrations.library. The dependencies.cfg is also missing in this PR. Update your local file and include it in the PR. The PR must successfully compile for further review.

v0.6.0 does not include the changes needed for the build to finish as far as i see it

zehnm commented 3 years ago

It doesn't include the changes from your intg.lib PR yet, but other required changes. I'll create a new intg.lib release.

nikos1988 commented 3 years ago

OK, it builds fine now :)

nikos1988 commented 3 years ago

OK, icons should be all okay now