YIO-Remote / remote-software

💎 YIO Remote Software repository
GNU General Public License v3.0
164 stars 21 forks source link

Configurable websocket port and using real hostname for zeroconf service publishing #514

Closed zehnm closed 3 years ago

zehnm commented 3 years ago

The WebSocket server port can be configured with the environment variable YIO_WEBSOCKET_PORT. If not specified, the old default port 946 is used.

This is a preparation to use a non-privileged port. It needs further coordination with remote-os and web-configurator and best done at the next major release since it's a breaking change.

With the env variable it's now possible to use the websocket API on Linux for development and testing.

@martonborzak please review the hostname simplification in the zeroconf service publishing. I've tested a freshly created SD card image and it used the same name with the mac address suffix. The advantage of retrieving the real hostname is that it now also works if the user changed the hostname of his remote.

This closes #489

martonborzak commented 3 years ago

Looks good @zehnm ! Thanks!