Closed zehnm closed 4 years ago
@zehnm Is this absolutely necessary? We're adding ~30 lines of comments to every file in the source code? Legally, is this required? If it's not then I'm reluctant to do it for the following reasons:
I have just copied the task to each repository. You are right, for the web environment it doesn't make sense for every file. Legally nothing is required, but good practice for open source projects. My pragmatic suggestion: add the information to the main html / js file only. Does that work for you?
I have just copied the task to each repository. You are right, for the web environment it doesn't make sense for every file. Legally nothing is required, but good practice for open source projects. My pragmatic suggestion: add the information to the main html / js file only. Does that work for you?
All sub-files could refer to the COPYING file with a copy of the GNU GPL. That would make one line instead of 30 in each file. And also when modifying, you have to alter only 1 file instead of many many many :P
So each file would be something like:
// Please refer to the LICENSE.md file
What about:
// @License GPL-3.0-or-later - please refer to LICENSE.md file for details
This contains the official spdx license tag and is human readable. Or:
// @License GPL-3.0-or-later <https://spdx.org/licenses/GPL-3.0-or-later.html>
I'll let you guys pick which one out of those 2, let me know and I can update
I vote for
// @License GPL-3.0-or-later - please refer to LICENSE.md file for details
I'm fine with both, let's @martonborzak decide :-)
Well, let's do the short one then.
Same task as YIO-Remote/remote-software#349
Expected Behavior or Design
The YIO Remote software is licensed under GPL v3 or later (see license information in each GitHub repository). This should not just be reflected in the LICENSE.md file but also in every source file.
Current Behavior or Design
Almost no source file has a license information.
Possible Solution
Add the same file header to each and every source file. The new wifi control source files in feature/322-WiFi_rewrite branch have a file header defined. I suggest using this header as a template. See below in detailed description.
Detailed Description and Additional Information
Suggested license template for new files
I.e. entirely written by one author:
Suggested license template for derived files
I.e. using code from other GPL v3 compatible sources:
Example wifi_wpasupplicant.h