search

YIZHUANG / react-multi-carousel

A lightweight production-ready Carousel that rocks supports multiple items and server-side rendering with no dependency. Bundle size 2kb.
MIT License
1.25k stars 286 forks source link

keyBoardControl not working in version 2.6.3 #276

Open pejman1 opened 2 years ago

pejman1 commented 2 years ago

after updating to version 2.6.3 and 2.6.5 keyboard control does not work downgrade to the version 2.6.2 will solve the problem

windows 10 - react version 17

pejman1 commented 2 years ago

@YIZHUANG

YIZHUANG commented 2 years ago

@tegaadigu could https://github.com/YIZHUANG/react-multi-carousel/pull/252 have caused the issue?

tegaadigu commented 2 years ago

@YIZHUANG yes and i did create a fast follow fix for this:

Please review:

https://github.com/YIZHUANG/react-multi-carousel/pull/260

YIZHUANG commented 2 years ago

@YIZHUANG yes and i did create a fast follow fix for this:

Please review:

260

Thank you, is it possible to make it work for most of the users for now by removing the check for isChildOfCarousel? Cause I don't think I have the time to review the PR yet

tegaadigu commented 2 years ago

@YIZHUANG yes that logic has been removed in the above PR - it doesnt check fo childCarousel anymore.

https://github.com/YIZHUANG/react-multi-carousel/pull/260

pejman1 commented 2 years ago

The problem has not fixed yet. I have just installed version 2.8.0 and keyBoardControl doesn't work for me but version 2.6.1 is okay.

YIZHUANG commented 2 years ago

The problem has not fixed yet. I have just installed version 2.8.0 and keyBoardControl doesn't work for me but version 2.6.1 is okay.

Can you open a PR for this?

Sammii commented 2 years ago

The problem has not fixed yet. I have just installed version 2.8.0 and keyBoardControl doesn't work for me but version 2.6.1 is okay.

Can you open a PR for this?

Hi @YIZHUANG , I see above that @tegaadigu already opened a PR to fix this 9 months ago. Is there some reason it's still not merged?

tegaadigu commented 2 years ago

@YIZHUANG i had a pr open to resolve this since may of 2021 - please merge when you can https://github.com/YIZHUANG/react-multi-carousel/pull/260

pejman1 commented 2 years ago

@YIZHUANG still the problem has not fixed after a year. since version 2.6.1 !!!