search

YIZHUANG / react-multi-carousel

A lightweight production-ready Carousel that rocks supports multiple items and server-side rendering with no dependency. Bundle size 2kb.
MIT License
1.25k stars 286 forks source link

react-multi-carousel-dot-list should not use position:absolute when renderDotsOutside is set #327

Open zehawki opened 2 years ago

zehawki commented 2 years ago

Describe the bug react-multi-carousel-dot-list should not use position:absolute when renderDotsOutside is set. Together with bottom:0, it places the dots at the bottom of the page, which is hardly the intention.

Note that when this is fine when renderDotsOutside is NOT set.

Expected behavior The dots should be placed at the bottom of the element, rather than the bottom of the page.

Version v2.8.0

Emmanuel-umeh commented 1 year ago

One year later and this is still an issue

Emmanuel-umeh commented 1 year ago

Solved this by wrapping your carousel component in a div with position as relative, and then setting a padding bottom on the div to a desired size, example 5px. Hope this helps👍🏼