YIZHUANG / react-multi-carousel

A lightweight production-ready Carousel that rocks supports multiple items and server-side rendering with no dependency. Bundle size 2kb.
MIT License
1.25k stars 286 forks source link

slidesToSlide-To accept 0 as truthy value #412

Open sathya-sundar opened 8 months ago

sathya-sundar commented 8 months ago

We are using react-multi-carousel for our app and we are hit with below limitation / issue.

Given: Some of the slides in our carousel have more than 1 buttons on it. When: those slides are focused, 1st button get focus. Then: i press right Expected: Focus should move to next button on the same slide. Actual: Focus moving to next slide

I found that if slidesToSlide can be dynamically set to 0 when such slides are focused, i will be able to block the slide transition until the focus is on last button.

In this PR, i have made slidesToSlide to be defaulted to 1, only of responsive.slidesToSlide is undefined, so that 0 is accepted as a truthy value.