search

YJSGframework / yjsg

YJSG Template Framework Plugin
GNU General Public License v2.0
17 stars 14 forks source link

Corrected bug: PHP AJAX messages in multilanguage [3] #23

Closed ptopenweb closed 9 years ago

ptopenweb commented 9 years ago

Needs to know the current language so it can show the messages in other languages, if not, only english.

ptopenweb commented 9 years ago

why are the others wrong? They are different files...

danyj commented 9 years ago

they are missing the translation https://github.com/ptopenweb/yjsg/commit/d5e39b2c88c537b8e5ce94f98b9b14d10d00df4e#diff-28359853619a6ed8bf92587a36e6faf0R193

https://github.com/ptopenweb/yjsg/commit/1bb9ae7de75cbde14d390071356e0253fdb90e4f#diff-a4bfeb670f705ae409f7d19dd0cde22aR424

This one is correct https://github.com/ptopenweb/yjsg/commit/b19b82a8343abd3307ffb6e7eee55417707dd63a#diff-09d2054a40ee7665febeea747efdb9e3R35

Have you tested on 2.5 ?

ptopenweb commented 9 years ago

Missing? No They are in the other pull request that is on standby https://github.com/YJSGframework/yjsg/pull/18/files#diff-a4bfeb670f705ae409f7d19dd0cde22aL422 https://github.com/YJSGframework/yjsg/pull/18/files#diff-28359853619a6ed8bf92587a36e6faf0L191

ptopenweb commented 9 years ago

I don't have a 2.5 installation to test.

danyj commented 9 years ago

OK , will reopen those 2. Everything must be tested on 2.5 first , they are many members who did not upgrade to 3.x , we cant leave them out.

ptopenweb commented 9 years ago

ok i understand that. Please do test in 2.5. I try allways to do the changes in "legacy" (for 2.5? or for old yjsg?) folder too, but i never know.

danyj commented 9 years ago

legacy folder is not 2.5 , legacy is for templates made before yjsg plugin.

danyj commented 9 years ago

scratch previous comment, I had wrong tab open

ptopenweb commented 9 years ago

will close these 3 pulls and merge to my master so they go in the other pull request