Open YKimball-Smith opened 4 years ago
There's a mismatch in file formats. In your HTML you're referencing JPG
and PNG
images while all the images in your images
folder are SVG
.
I just changed all the images to JPG and updated the index on github but it doesn't seem to change anything. Do you think it is just taking some time to update?
The hero image is displaying.
Remove the inline style style="width:100%"
and add the Bootstrap responsive image HTML class img-fluid
instead:
<img class="img-fluid" src="image/img-moon-phases.jpg" alt="Infographic of Moon phases.">
Also, you don't need to say "image of" within the alt text, but you could say something like "Diagram or Infographic of" to help users visualize what kind of image it is.
oh okay I will try it out
Hi the images still are not showing up but rather showing just an icon indicating there should be a photo there. Do you have any ideas about this?
im just very confused
One example:
Update to .png
to reference:
https://github.com/YKimball-Smith/single-serving/blob/master/image/moon-phase-1.png
Double-check the rest and update accordingly.
I see what you are saying because I did have that one image saved as a .png but the rest of my images are saved as .jpg and I source them as .jpg so I'm not sure how else to change it.
It looks like your repo image
folder still includes .svg
versions, not .jpg
versions:
https://github.com/YKimball-Smith/single-serving/tree/master/image
Can you look at what is happening with my code in my table? None of the images in my table are showing up.