YKimball-Smith / Lunar-Phase

https://ykimball-smith.github.io/Lunar-Phase/
0 stars 0 forks source link

Issue getting images to attach/show up #1

Open YKimball-Smith opened 4 years ago

YKimball-Smith commented 4 years ago

Can you look at what is happening with my code in my table? None of the images in my table are showing up.

jgagne commented 4 years ago

There's a mismatch in file formats. In your HTML you're referencing JPG and PNG images while all the images in your images folder are SVG.

YKimball-Smith commented 4 years ago

I just changed all the images to JPG and updated the index on github but it doesn't seem to change anything. Do you think it is just taking some time to update?

jgagne commented 4 years ago

The hero image is displaying.

https://github.com/YKimball-Smith/single-serving/blob/4dc99314306d7999d8e3b1a5c25aa58ca11e485a/index.html#L51

Remove the inline style style="width:100%" and add the Bootstrap responsive image HTML class img-fluid instead:

<img class="img-fluid" src="image/img-moon-phases.jpg" alt="Infographic of Moon phases.">

Also, you don't need to say "image of" within the alt text, but you could say something like "Diagram or Infographic of" to help users visualize what kind of image it is.

YKimball-Smith commented 4 years ago

oh okay I will try it out

YKimball-Smith commented 4 years ago

Hi the images still are not showing up but rather showing just an icon indicating there should be a photo there. Do you have any ideas about this?

YKimball-Smith commented 4 years ago

im just very confused

jgagne commented 4 years ago

One example:

https://github.com/YKimball-Smith/single-serving/blob/8994f78bd413f63365b4342b726cd75203580ab5/index.html#L97

Update to .png to reference: https://github.com/YKimball-Smith/single-serving/blob/master/image/moon-phase-1.png

Double-check the rest and update accordingly.

YKimball-Smith commented 4 years ago

I see what you are saying because I did have that one image saved as a .png but the rest of my images are saved as .jpg and I source them as .jpg so I'm not sure how else to change it.

jgagne commented 4 years ago

It looks like your repo image folder still includes .svg versions, not .jpg versions:

https://github.com/YKimball-Smith/single-serving/tree/master/image

a-lot-of-svg