YS-L / csvlens

Command line csv viewer
MIT License
2.47k stars 41 forks source link

& and * on Windows? #82

Closed amreus closed 3 months ago

amreus commented 3 months ago

When typing / I get prompted for the regex to search for.

I also expected to be prompted for a regex when typing & or * but nothing appears to happen. Do I misunderstand how to use the filter functions?

Thanks.

YS-L commented 3 months ago

Your understanding is correct - typing & or * should show a prompt for regex as well. Curious if there are other key bindings that don't work as expected or are these the only two?

If you could share a bit more information about your system that could be helpful.

amreus commented 3 months ago

✔️ Tab for changing modes. ✔️ hjkl works for navigation in all modes. ✔️ ctrl-f & ctr-b ✔️ ctrl-u & ctrl-d ✔️ G & g ✔️ <n>G goto line ✔️ / for searching prompt ✔️ n & N& and * for filtering don't appear to do anything ✔️ Shift-Dn for sorting ❌ < & > not working in any mode ❌ # and @ not working (cell mode) ✔️ y copying works ✔️ Enter

I made a scoop manifest which is how I installed csvlens. However I get the same results from the direct download.

https://github.com/ScoopInstaller/Main/blob/master/bucket/csvlens.json

I use Windows Terminal (Portable) Version: 1.20.240506001

Edition Windows 10 Home
Version 22H2
Installed on    ‎11/‎22/‎2020
OS build    19045.4291
Experience  Windows Feature Experience Pack 1000.19056.1000.0
YS-L commented 3 months ago

Thanks for the detailed report! I will get to this once I have access to a Windows machine to test and reproduce.

amreus commented 3 months ago

I'm willing to run test versions if it would help. I can also compile and test from a test branch of the repo. I'm no programmer, but let me know it I can help.

YS-L commented 3 months ago

@amreus Thank you! Based on the symptoms I suspect the issue is related to shift key handling in Windows. I have a possible fix in https://github.com/YS-L/csvlens/pull/84. It would be great if you can test if it works.

amreus commented 3 months ago

Works 100%, thank you. This is a wonderful tool. And thank you for considering Windows a worthwhile platform - many projects unfortunately do not.

YS-L commented 3 months ago

This has been very helpful, thank you!