search

YSCEDC / YSCE

YSFlight Community Edition
BSD 3-Clause "New" or "Revised" License
13 stars 4 forks source link

Change fog distance from statute miles to nautical miles #31

Closed XA-38 closed 1 year ago

XA-38 commented 1 year ago

I noticed a couple of other instances of 1609.0 in fsguinewflightdialog.cpp related to the fog visibility distance. I changed these to 1852.0 so that these distances are in nautical miles.

Skipper-is commented 1 year ago

Ah good spot. Will review.

Skipper-is commented 1 year ago

Had a quick look. Looks good, but need to check it compiled to see it working, and double check it against the wording of the menu. May require an update to the language file to reflect this.

JOBBIN9422 commented 1 year ago

It might be worth moving these conversions & other hard-coded values into a YSFlight constants header/class eventually (just something to think about)

decaff42 commented 1 year ago

it would be nice to have unit conversion or definition handled in one unified place.

Skipper-is commented 1 year ago

There are some, well, there is a meters to NM, not sure if there is a visa versa

On Tue, 27 Jun 2023, 22:51 decaff42, @.***> wrote:

it would be nice to have unit conversion or definition handled in one unified place.

— Reply to this email directly, view it on GitHub https://github.com/YSCEDC/YSCE/pull/31#issuecomment-1610267537, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG2ZPNPN6YTVILSFP4OJ65LXNNIXJANCNFSM6AAAAAAZSIIHUY . You are receiving this because you modified the open/close state.Message ID: @.***>