search

YT-Advanced / WSA-Script

Integrate Magisk root and Google Apps into WSA (Windows Subsystem for Android) with GitHub Actions
https://YT-Advanced.github.io/WSA-Script/
GNU Affero General Public License v3.0
780 stars 166 forks source link

[Bug] Redundant portion of Custom Builder #970

Closed robbely closed 10 months ago

robbely commented 10 months ago

Steps to reproduce

(build with no root solution)

Expected behaviour

The custom builder script asks for "Magisk version" even if "Root solution" is set to "None". If I remove the command line switch for magisk version, there is a build error.

With root solution set to none (or different root solution), what does this switch do, and why does removing it giver an error when magisk isnt being used? Also will magisk still be there in some form in my custom build?

Actual behaviour

(build error when switch removed)

Windows version

10.0.19045.3693

Build Issue number

968

Version requirement

github-actions[bot] commented 10 months ago

Hello robbely.
Thanks for sending an issues. Now our admin is inactive, just waiting and he will reply you soon.
Hope you have a nice day.

https://github.com/YT-Advanced/WSA-Script/actions/runs/7022210010

YT-Advanced commented 10 months ago

You don't need to care about this, because my script will not apply root