search

YU000jp / logseq-plugin-quickly-para-method

Provides quick menu for The PARA method.
MIT License
12 stars 0 forks source link

"/Resources" appends comma to end of first block #25

Open jwhonce opened 3 months ago

jwhonce commented 3 months ago

The command correctly adds Resources to the tags:: property as expected, additionally it appends an unexpected comma to the end of the block. The Resources page is updated as expected.

Page Properties:

tags:: associate
github-id:: 
gitlab-id:: 
jira-id::

After /Resources command:

tags:: associate, Resources
github-id:: 
gitlab-id:: 
jira-id::,

Notice tailing comma.

YU000jp commented 3 months ago

It is a bug. The use of "," was to address a bug that prevented page-tags from being updated.

YU000jp commented 2 months ago

Change:

@jwhonce I released a new version. Try it, please. It is not yet known whether this bug has been completely resolved for each condition.

jwhonce commented 2 months ago

Using plugin v1.8.6 and logseq 0.10.8

tags:: 
page-type:: [[Projects]] 
architect:: 
lead:: 
github-url:: 
deadline:: 
priority:: #A
marker:: DOING
tags:: Projects,

The tags:: property was duplicated.

YU000jp commented 2 months ago

Using plugin v1.8.6 and logseq 0.10.8

tags:: 
page-type:: [[Projects]] 
architect:: 
lead:: 
github-url:: 
deadline:: 
priority:: #A
marker:: DOING
tags:: Projects,

The tags:: property was duplicated.

Thank you for reporting this. It seems that the plugin API failed to delete the property and it was duplicated. I will fix it.

jwhonce commented 2 months ago

Happy to help test.

YU000jp commented 2 months ago

I can't reproduce it properly. If "tags::" occurs temporarily and the value is empty, please delete it manually.

jwhonce commented 2 months ago

My steps:

  1. I create empty page
  2. Apply one of my /Template's (which has page properties with tags::)
  3. /Page-Tag (Resources)
YU000jp commented 2 months ago

I see. In your usage, you create an empty property "tags::" for input in the template, right?

jwhonce commented 2 months ago

tags:: has one value I use in queries. I suspect with a little thought, I could use page-type for my meta-data and leave tags for your plugin.

YU000jp commented 2 months ago

tags:: has one value I use in queries. I suspect with a little thought, I could use page-type for my meta-data and leave tags for your plugin.

You want to use "page-type::" instead of "tags::"? If consistency can be achieved, it may be possible to make "specifying the property-name" an option.