search

YU000jp / logseq-plugin-show-weekday-and-week-number

Show weekday and week number beside journal titles. / Show the mini-calendar that has navigational links on Daily Journal.
https://discuss.logseq.com/t/show-week-day-and-week-number/12685/1
MIT License
37 stars 1 forks source link

Bug in week numbers on the mini-calendar starting 2024-W13 #137

Open elaine-threepwood opened 1 month ago

elaine-threepwood commented 1 month ago

I see the label "W13" repeated both for week 13 (March 25-31) and week 14 (April 1-7). Starting from there, all the following week numbers are wrong because of this

image

YU000jp commented 1 month ago

Sorry, I couldn't find a way to reproduce the bug. Once I figure out how to reproduce this bug, I plan to modify the calculation method for calculating the week number. Probably, I'm going to change the day of the week to identify the week number. Did you choose ISO format and, any start of the week config?

YU000jp commented 1 month ago

There may also be a time zone effect. Checking it up.

AvanBerne commented 1 month ago

I saw this issue too, but now with the new release (v1.53.1) it has resolved.

AvanBerne commented 1 month ago

btw, I am using ISO format, and all other relevant settings are on default. The only other thing I noticed is that the weekend between W13 and W14 is a holiday weekend, where both the Sunday and the Monday are a holiday in my region (NL). Also, since elaine-threepwood hasn't answered - from their screenshot it seems they are using a southern european language (possibly Italian), so I would guess they are also using ISO(EU) week format.

YU000jp commented 1 month ago

btw, I am using ISO format, and all other relevant settings are on default. The only other thing I noticed is that the weekend between W13 and W14 is a holiday weekend, where both the Sunday and the Monday are a holiday in my region (NL). Also, since elaine-threepwood hasn't answered - from their screenshot it seems they are using a southern european language (possibly Italian), so I would guess they are also using ISO(EU) week format.

I will verify based on your information. To prevent other bugs from occurring, I plan to reproduce and isolate this bug under similar conditions as much as possible.