search

YUICompressor-NET / YUICompressor.NET

Port of Yahoo!'s Java YUICompressor to .NET
BSD 3-Clause "New" or "Revised" License
122 stars 61 forks source link

Ecmascript20 #32

Open trullock opened 6 years ago

trullock commented 6 years ago

Fixes #29 by updating EcmaScript.NET reference

Had to update to Net4.5

I've had to drop CLS compliance because EcmaScript.NET now isnt CLS compliant under Net4.5.

I'd like to see this not be a problem for a 3.0.0.0 (maybe pre-release) version. I'll help get a new version of EcmaScript.NET CLS compliant in the background, but for now I'd really benefit from a YUIC that doesnt have this bug

trullock commented 6 years ago

I see the other PRs have .net version upgrades and pushback on wanting netstandard support.

I'm happy to help do this

Shall we discuss that on #22 and decide what we want?

freeranger commented 6 years ago

@trullock Why was the net45 upgrade necessary for this PR?

trullock commented 6 years ago

because Ecmascript.Net 2.0 which contains the bugfix has been updated to 45

PureKrome commented 6 years ago

@trullock more info now in - please refer to #22 . Can this PR either be closed and a new one opened OR this one updated?

PureKrome commented 6 years ago

With PR #33 merged, can this be now closed @trullock ?