search

YUICompressor-NET / YUICompressor.NET

Port of Yahoo!'s Java YUICompressor to .NET
BSD 3-Clause "New" or "Revised" License
122 stars 61 forks source link

Microsoft Certification requirement #4

Closed code-for-coffee closed 8 years ago

code-for-coffee commented 10 years ago

Microsoft Certification requires all referenced DLLs to have a provided "Company" name. Added one to pass this check.

PureKrome commented 10 years ago

@code-for-coffee heya! thanks for this PR.

Question - why is this important? (just curious)....

code-for-coffee commented 10 years ago

@PureKrome - Microsoft requires any DLLs included in your application to have the "Company" name filled out in the assembly when having the application certified. I thought to submit this PR because it'd help anyone who uses this library from Nuget.

PureKrome commented 9 years ago

@freeranger buddy - I agree with the PR in principle - I don't really agree with the value of the AssemblyCompany.

Any thoughts what should be put in here, instead?

[assembly: AssemblyCompany("Open Source Software")] ?

i really don't have a quick answer on this :frowning:

code-for-coffee commented 9 years ago

@PureKrome I think "Open Source Software" works just fine. I only attributed your name and Yahoo's because I wasn't sure what else to put. :)

freeranger commented 9 years ago

You could put "(none)"? The PureRanger Partnership? :) I don't have any strong views either way tbh....

PureKrome commented 9 years ago

@code-for-coffee can u change it to The PureRanger Partnership please?

code-for-coffee commented 9 years ago

@PureKrome done. Thanks for taking the time to address this.