search

YUNG-GANG / YUNGs-API

API for my Minecraft mods
GNU Lesser General Public License v3.0
22 stars 12 forks source link

Make fastSpawn only run in dev, fixing mod conflicts. #28

Closed Ampflower closed 2 years ago

Ampflower commented 2 years ago

This makes MinecraftServerMixin an entirely dev-only mixin.

Additionally, this sets the priority of the mixin to 500 and makes all the constant modifiers not required to help with conflicts in the event that any previously conflicting mods, such as ServerCore, happens to be installed at the same time. This didn't work as expected; this part of the change has been reverted to hard crash instead should both be present in dev at the same time.

Resolves

Fixes #26 Fixes Wesley1808/ServerCore#23

yungnickyoung commented 2 years ago

Hey, thanks for this. To clarify - this PR:

  1. Makes the mods fully compatible in a production environment
  2. Maintains the API's fast spawn behavior in a development environment
  3. Results in a crash if both mods are used in a development environment

Is this correct?

Ampflower commented 2 years ago

Yes, all 3 are correct. Should also apply to Forge as well, although, I don't have any known conflicting mods to test with under Forge.

yungnickyoung commented 2 years ago

Gotcha, thanks!