search

YUNG-GANG / YUNGs-Better-End-Island

Minecraft mod that enhances the Ender Dragon arena
GNU Lesser General Public License v3.0
4 stars 4 forks source link

More Dragon Eggs #13

Closed Fail-gh closed 9 months ago

Fail-gh commented 1 year ago

Add an option to spawn a dragon egg with each dragon death as More Dragon Eggs does not work with this mod

liangmoe commented 10 months ago

is there any solution? ive tried Adventurez and dragonmount, they both have option such as replenishing dragon egg and just not working😭

Linguardium commented 9 months ago

the underlying problem is Yung overwrites the method but doesnt use @Overwrite meaning it silently causes mods to fail instead of crashing. if it crashed, players would know that yung was breaking a bunch of other mods by replacing methods entirely.

Since yung is the one completely replacing the methods, it would be up to them to add a compat for the mods they break

yungnickyoung commented 9 months ago

The unfortunate thing about vanilla dragon fight code is that it's very bad and difficult to overhaul to the extent I've attempted in this mod. I opted to inject instead of overwrite so that other mod devs can inject with higher priority if they need to, which so far has seemed to be a good choice. That being said, I'll take a look and see if I can get it working properly with this mod.

yungnickyoung commented 9 months ago

Added in v2.0.5.