search

YUNG-GANG / YUNGs-Better-Fortresses

A complete overhaul to vanilla Nether Fortesses!
GNU Lesser General Public License v3.0
4 stars 4 forks source link

Crash upon entering the Nether #3

Open SubordinalBlue opened 1 year ago

SubordinalBlue commented 1 year ago

Caveat: this is with the latest AoF6, 1.5.0, which inclued YBF 1.0.5.

Upon attempting to enter the nether, a freshly installed server will hang long enough to disconnect clients.

Everything seems OK when I tried again with a fresh world and no YBF.

Unclear if this is soley due to YBF, or an interaction with another mod in AoF6.

RisingEclipse commented 1 year ago

Logs?

ImAK9 commented 1 year ago

Can confirm this happens on latest AOF6 (1.5.0) https://aofpaste.com/hujagezela.sql

yungnickyoung commented 1 year ago

Would you be able to isolate the mod combination that causes the issue? I don't see anything about my mods in the logs or thread dump.

SubordinalBlue commented 1 year ago

You may find this thread (link at bottom) from AoF's discord with more reports a little helpful. The common symptom seems to be that first generating the nether (when YBF is installed) is causing a large enough cpu usage spike that the watchdog will step in.

Doesn't happen 100% of the time either; I've repeated the experiment with a fresh world each of 3 times, and was able to enter the nether (1 player, server running on same PC), but it did seem quite slow when it did succeed. Coincedentally(?), those successful 3 times (same seed) had a nether fortress right at the portal location, coming from spawn.

Does happen enough that AoF discord has seen several reports of the problem.

https://discord.com/channels/570630340075454474/1084252462887747584

LuckySkye13 commented 11 months ago

This is also happening on the 1.20.1 latest version, once a better fortress spawns in, all entities hang forever, chunks stop generating, no crash log gets created, and neither the debug or latest log even mention anything to do with any Yung mod... the only reason I even tried removing the better fortresses mod is because I recognized your work in the architecture, otherwise I would've never have figured out what was causing it

SubordinalBlue commented 11 months ago

Oh, hey, long time since I've checked back here.

I'll add this quote from an AoF dev/contributor on discord:

I did a test and found that, unlimited, Yungs better ocean monuments can pull 40GB of ram...seriously all the structure mods in the pack activating DFU will CONSUME ram. pregenerate your world with modernfix active and it will cache all the fixed up structures, which will help, but updating better ocean monuments will help significantly even without that.

(not entirely sure if this was exactly what was happening with Nether fortresses, but would fit, afaik)

yungnickyoung commented 11 months ago

Latest version of all my mods on 1.20+ fixes the above mentioned DFU issue.

@LuckySkye13 Regarding the world deadlocking - I would need a stack trace (with Spark or another tool) to help you diagnose the issue, but I suspect it's caused by a mod that modifies entities such as skeletons or wither skeletons. I've seen those types of issues a few times in the past

doncarlosx commented 5 months ago

I was able to reliably repro the deadlock with https://www.curseforge.com/minecraft/mc-mods/wither-skeleton-tweaks.

My full modlist that deadlocks every time at the same spot for a given seed is below. Removing WitherSkeletonTweaks-1.20.1-9.1.0.jar allows it to generate past that spot.

AdvancementPlaques-1.20.1-forge-1.5.1.jar
aether_emissivity-1.20.1-1.0.0-neoforge.jar
aether_enhanced_extinguishing-1.20.1-1.0.0-neoforge.jar
aether-1.20.1-1.2.0-neoforge.jar
alexscaves-1.1.4.jar
alexsmobs-1.22.8.jar
almostunified-forge-1.20.1-0.9.0.jar
alternate_current-mc1.20-1.7.0.jar
AmbientSounds_FORGE_v5.3.9_mc1.20.1.jar
amendments-1.20-1.1.10.jar
Apotheosis-1.20.1-7.3.3.jar
ApothicAttributes-1.20.1-1.3.1.jar
aquamirae-6.API15.jar
architectury-9.2.14-forge.jar
ars_creo-1.20.1-4.1.0.jar
ars_nouveau-1.20.1-4.9.0-all.jar
athena-forge-1.20.1-3.1.2.jar
AttributeFix-Forge-1.20.1-21.0.4.jar
balm-forge-1.20.1-7.2.2.jar
BetterAdvancements-1.20.1-0.3.2.162.jar
betterarcheology-1.1.7-1.20.1.jar
bettercombat-forge-1.8.4+1.20.1.jar
blockui-1.20.1-1.0.151-BETA.jar
blossom.jar
blueprint-1.20.1-7.0.1.jar
blur-forge-3.1.1.jar
bobby-1.20.1_v5.0.1.jar
Bookshelf-Forge-1.20.1-20.1.9.jar
Botania-1.20.1-443-FORGE.jar
caelus-forge-3.1.0+1.20.jar
callablehorses-1.20.1-1.3.0.1.jar
canary-mc1.20.1-0.3.3.jar
carryon-forge-1.20.1-2.1.2.7.jar
chalk-1.20.1-1.6.3.jar
charmofundying-forge-6.5.0+1.20.1.jar
Chimes-v2.0.1-1.20.1.jar
Chipped-forge-1.20.1-3.0.4.jar
Chunky-1.3.136.jar
citadel-2.5.4-1.20.1.jar
citresewn-1.20.1-5.jar
classicbar-1.20.1-2.jar
cloth-config-11.1.118-forge.jar
cloudstorage-1.4.0-1.20.jar
Clumps-forge-1.20.1-12.0.0.3.jar
ComplementaryReimagined_r5.1.1.zip
connectivity-1.20.1-5.5.jar
Continents_1.20.4_v1.1.4.jar
Controlling-forge-1.20.1-12.0.2.jar
cookingforblockheads-forge-1.20.1-16.0.3.jar
craftingcraft-forge-1.20-16.0.0.jar
craftingtweaks-forge-1.20.1-18.2.3.jar
create_central_kitchen-1.20.1-for-create-0.5.1.f-1.3.10.jar
create_enchantment_industry-1.20.1-for-create-0.5.1.f-1.2.8.jar
create_jetpack-forge-4.2.1.jar
create_power_loader-1.4.0-mc1.20.1.jar
create-1.20.1-0.5.1.f.jar
createaddition-1.20.1-1.2.3.jar
createbigcannons-forge-1.20.1-0.5.3.b.jar
createoreexcavation-1.20-1.4.2.jar
CreativeCore_FORGE_v2.11.25_mc1.20.1.jar
creeperoverhaul-3.0.2-forge.jar
cristellib-1.1.5-forge.jar
cupboard-1.20.1-2.6.jar
curios-forge-5.7.2+1.20.1.jar
DarkPaintings-Forge-1.20.1-17.0.4.jar
deeperdarker-forge-1.20.1-1.2.1.jar
Detail-Brush-1.6-1.20.zip
domesticationinnovation-1.7.1-1.20.1.jar
domum_ornamentum-1.20-1.0.166-BETA-universal.jar
effortlessbuilding-1.20.1-3.7-all.jar
elytraslot-forge-6.3.0+1.20.1.jar
embersrekindled-1.20.1-1.1.1.jar
emi-1.1.3+1.20.1+forge.jar
EnchantmentDescriptions-Forge-1.20.1-17.0.14.jar
endermanoverhaul-forge-1.20.1-1.0.4.jar
endertrigon-1.20.1-1.0.jar
endrem_forge-5.2.3-R-1.20.X.jar
entity_model_features_forge_1.20.1-1.3.jar
entity_texture_features_forge_1.20.1-5.2.3.jar
entityculling-forge-1.6.2-mc1.20.1.jar
ExplorersCompass-1.20.1-1.3.3-forge.jar
exposure-1.20.1-1.4.1-forge.jar
FA+All_Extensions-v1.3.zip
FarmersDelight-1.20.1-1.2.4.jar
fastasyncworldsave-1.20.1-1.5.jar
FastFurnace-1.20.1-8.0.2.jar
fastpaintings-1.20-1.2.4.jar
FastSuite-1.20.1-5.0.1.jar
ferritecore-6.0.1-forge.jar
firstperson-forge-2.3.4-mc1.20.1.jar
flatbedrock-forge-3.0.1-build.18+mc1.20.1.jar
FreshAnimations_v1.9.zip
ftbbackups2-forge-1.20-1.0.23.jar.disabled
ftb-library-forge-2001.1.5.jar
ftb-ultimine-forge-2001.1.4.jar
functionalstorage-1.20.1-1.2.7.jar
fusion-1.1.1-forge-mc1.20.1.jar
geckolib-forge-1.20.1-4.4.2.jar
GildedSherds-Forge-1.20.1-1.0.2.jar
hauntedharvest-1.20-3.1.19.jar
Highlighter-1.20.1-forge-1.1.9.jar
iceandfire-2.1.13-1.20.1-beta-4.jar
Iceberg-1.20.1-forge-1.1.21.jar
ichphilipp-s-endcity-vanilla-v1-1-1-18-1-e640.zip
Incendium_1.20.4_v5.3.4.jar
iwannaskate-1.2.0.jar
Jade-1.20.1-forge-11.7.1.jar
JadeAddons-1.20.1-forge-5.2.2.jar
jeed-1.20-2.1.11.jar
jei-1.20.1-forge-15.3.0.4.jar
jepp-1.20-1.1.2.jar
Kiwi-1.20.1-forge-11.5.5.jar
kotlinforforge-4.10.0-all.jar
KryptonReforged-0.2.3.jar
kubejs-create-forge-2001.2.5-build.2.jar
kubejs-forge-2001.6.4-build.138.jar
L_Enders_Cataclysm-1.90 -1.20.1.jar
labels-1.20-1.20.1.jar
loadingbackgrounds-1.1.0-forge.jar
loadingbackgrounds-2.0.1.zip
loadingbackgrounds-oceans-1.0.0.zip
loadingbackgrounds-structures-1.0.1.zip
lootjs-forge-1.20.1-2.11.0.jar
lost-libraries-1.1.jar
LucasDotje's+Story+Mode+Storm.zip
mes-1.3-1.20-forge.jar
minecolonies-1.20.1-1.1.507-BETA.jar
mns-1.0-1.20-forge.jar
mobbattlemusic-1.20.1-1.1.1-all.jar
modelfix-1.14.jar
modernfix-forge-5.14.0+mc1.20.1.jar
monobank-1.20.1-1.1.4.jar
moonlight-1.20-2.11.4-forge.jar
moonlit.jar
MouseTweaks-forge-mc1.20-2.25.jar
multipiston-1.20-1.2.31-ALPHA.jar
mvs-4.1.1-1.20-forge.jar
NaturesCompass-1.20.1-1.11.2-forge.jar
netherportalfix-forge-1.20-13.0.1.jar
notenoughanimations-forge-1.7.1-mc1.20.1.jar
Nullscape_1.20.4_v1.2.4.jar
nyfsspiders-forge-1.20.1-2.1.1.jar
obscure_api-15.jar
Obscuria's-Brewing-1.19.zip
Obscuria's-Stylized-Potions-1.19.zip
Obscuria's-Tools-1.19.zip
oculus-flywheel-compat-1.20.1-0.2.4.jar
oculus-mc1.20.1-1.6.15a.jar
PassableFoliage-1.20.1-forge-8.2.1.jar
Patchouli-1.20.1-84-FORGE.jar
Pehkui-3.7.12+1.20.1-forge.jar
perfectplushies-forge-1.20.1-1.9.0.jar
Placebo-1.20.1-8.6.1.jar
player-animation-lib-forge-1.0.2-rc1+1.20.jar
polylib-forge-2000.0.3-build.126.jar
polymorph-forge-0.49.2+1.20.1.jar
Quark-4.0-438.jar
QuarkOddities-1.20.1.jar
Rats-1.20.1-8.1.2.jar
rechiseled-1.1.5c-forge-mc1.20.jar
rechiseledcreate-1.0.2-forge-mc1.20.jar
resourcefulconfig-forge-1.20.1-2.1.2.jar
resourcefullib-forge-1.20.1-2.1.23.jar
rhino-forge-2001.2.2-build.18.jar
salt-1.20.1-1.2.4.jar
saturn-mc1.20.1-0.1.3.jar
sawmill-1.20-1.3.8.jar
Searchables-forge-1.20.1-1.0.2.jar
SherdDuplication-Forge-1.20.1-2.0.7.jar
ShoulderSurfing-Forge-1.20.1-2.9.6.jar
sleep_tight-1.20-1.1.19.jar
smallships-forge-1.20.1-2.0.0-b1.1.jar
smoothboot(reloaded)-mc1.20.1-0.0.4.jar
smoothchunk-1.20.1-3.6.jar
snowyspirit-1.20-3.0.6.jar
Soft-Weather-1.0-1.20.zip
sootychimneys-1.20.1-1.2.1.jar
sophisticatedbackpacks-1.20.1-3.20.3.1029.jar
sophisticatedcore-1.20.1-0.6.9.569.jar
Stay_True_1.20.zip
Structory_1.20.2_v1.3.4.jar
Structory_Towers_1.20.4_v1.0.6.jar
structurize-1.20.1-1.0.708-RELEASE.jar
stylecolonies-1.3.2.jar
supermartijn642configlib-1.1.8-forge-mc1.20.jar
supermartijn642corelib-1.1.17-forge-mc1.20.1.jar
supplementaries-1.20-2.8.6.jar
suppsquared-1.20-1.1.14.jar
TelePass-forge-1.20.1-2.1.1.jar
Terralith_1.20.4_v2.4.11.jar
tidal-towns-1.2.jar
Tips-Forge-1.20.1-12.0.5.jar
titanium-1.20.1-3.8.27.jar
tlc_forge-1.0.3-R-1.20.X.jar
ToastControl-1.20.1-8.0.3.jar
toms_storage-1.20-1.6.5.jar
ToolStats-Forge-1.20.1-16.0.8.jar
Towns-and-Towers-1.12-Fabric+Forge.jar
towntalk-1.20.1-1.0.1.jar
trashslot-forge-1.20-15.1.0.jar
TravelersBackpack-1.20.1-9.1.12.jar
TravelersTitles-1.20-Forge-4.0.2.jar
trimeffects-1.1.1-forge.jar
twilightforest-1.20.1-4.3.2145-universal.jar
visuality-forge-2.0.2.jar
wares-1.20.1-1.2.7.jar
WitherSkeletonTweaks-1.20.1-9.1.0.jar
witherstormmod-1.20.1-4.0.1.1.jar
xali's Enchanted Books v0.12.0.zip
xali's Potions v1.0.zip
xenon-0.3.5+mc1.20.1.jar
xlpackets-1.18.2-2.1.jar
YeetusExperimentus-Forge-2.3.1-build.6+mc1.20.1.jar
YungsApi-1.20-Forge-4.0.4.jar
YungsBetterDesertTemples-1.20-Forge-3.0.3.jar
YungsBetterDungeons-1.20-Forge-4.0.3.jar
YungsBetterEndIsland-1.20-Forge-2.0.5.jar
YungsBetterJungleTemples-1.20-Forge-2.0.4.jar
YungsBetterMineshafts-1.20-Forge-4.0.4.jar
YungsBetterNetherFortresses-1.20-Forge-2.0.5.jar
YungsBetterOceanMonuments-1.20-Forge-3.0.4.jar
YungsBetterStrongholds-1.20-Forge-4.0.3.jar
YungsBetterWitchHuts-1.20-Forge-3.0.3.jar
YungsBridges-1.20-Forge-4.0.3.jar
YungsExtras-1.20-Forge-4.0.3.jar
Zeta-1.0-14.jar
Jadan1213 commented 5 months ago

I just ran into this issue as well with a mod pack. removing either wither skeleton tweaks or yung's better nether fortresses allowed the world to generate and work normally.

However! on a minimal install with Yung's nether fortresses and wither skeleton tweaks installed, they worked fine together. There may be a third mod conflicting with it.