search

YUNG-GANG / YUNGs-Better-Strongholds

Minecraft mod for enhancing vanilla strongholds
GNU Lesser General Public License v3.0
23 stars 11 forks source link

Eye Spy a fix! #30

Closed TelepathicGrunt closed 3 years ago

TelepathicGrunt commented 3 years ago

made eye spy now work with Better End strongholds and with End Remastered stronghold replacement structure if they are on. To do this, I made a custom criteria and predicate that is structure safe. if the structure passed in doesnt exist in the structure registry, it makes the predicate return false instead of instantly granting the advancement. The feature field for the custom predicate will use the structure registry instead of the bimap to resolve what structure to find

TelepathicGrunt commented 3 years ago

Will fix https://github.com/yungnickyoung/YUNGs-Better-Strongholds/issues/2

yungnickyoung commented 3 years ago

Thanks man. I really appreciate you going so far as to implement a more useful custom trigger. I went ahead and switched the EndRem criteria from the End Castle to the End Gate, since the custom eyes in ER actually bring you to the Gate, plus the fact that ER already has a custom achievement for finding the Castle.

I'll probably end up moving the custom trigger stuff into my API, but gonna go ahead and merge away.