YUSU-Dev / website

A UI testing and development environment for York SU website.
https://storybook.digital.yorksu.org/
GNU Affero General Public License v3.0
1 stars 1 forks source link

add min-h-svh #265

Closed nathanbillis closed 1 month ago

linear[bot] commented 1 month ago
WEB-345 iPhone SE xxs screen size issues

[https://yusu.freshdesk.com/a/tickets/37613](https://yusu.freshdesk.com/a/tickets/37613) I’ve got a few screenshots, the first two of the page that is worst affected, and then a few more showing small overlaps from the black base that don’t make the website non-functional (on my phone) but are still a little irritating, and maybe their effect would be worse on a smaller screen (I’ve got an iPhone SE 2nd gen so it’s relatively small already). The second one, where the black banner covers the whole screen, is the same page as the first, where the buttons are covered, but in landscape mode rather than portrait mode. The menu button ‘student sign in’ does enable me to sign in with no overlap issues; where there is a problem with the overlap is if you have added a product to your basket without signing in, then are prompted to sign in, which takes you to a page with options of how to sign in, where the overlap issues exist (see below, page is [https://yorksu.org/sign-in](https://yorksu.org/sign-in)). [image.png](https://uploads.linear.app/8edd7ce3-3571-4e0d-8edd-fbe875ce673d/5178e39a-0c8d-487b-abf1-7e5ddd4d3c4e/1238bd81-474c-41be-8f52-4fc04cdadc1c)

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying website-storybook with  Cloudflare Pages  Cloudflare Pages

Latest commit: 73fc534
Status:⚡️  Build in progress...

View logs

github-actions[bot] commented 1 month ago

Chromatic Results

Results
Build Results https://www.chromatic.com/build?appId=665dd850553053046c060910&number=632
Storybook Preview https://665dd850553053046c060910-vxtcuzcprb.chromatic.com/
Component Count 80