search

YYsuni / react18-json-view

JSON viewer for react18
https://jv.yysuni.com/
MIT License
236 stars 15 forks source link

Do not collapse string when selecting parts of it #33

Closed marcklingen closed 4 months ago

marcklingen commented 4 months ago

A user of our project reported this bug/idea and I thought that this could be a nice improvement for other users of react18-json-view as well: https://github.com/langfuse/langfuse/issues/1189

Recording of issue Untitled video - Made with Clipchamp

Suggestion: when a string is expanded and user selects parts of it, prevent collapse

@YYsuni what do you think about this? Is this something that's a general improvement of this project or rather implemented by us as an override for the string node?

YYsuni commented 4 months ago

Wow..., It's actually a terrible experience. I will fix it today.

YYsuni commented 4 months ago

v0.2.8-canary.1 available now.

YYsuni commented 4 months ago

@marcklingen Hello?

marcklingen commented 4 months ago

Thanks for the ping, will try this asap. And thanks for moving so fast, really appreciate it 🙌

marcklingen commented 4 months ago

Works perfectly, thank you 🙏