search

YaLTeR / niri

A scrollable-tiling Wayland compositor.
https://matrix.to/#/#niri:matrix.org
GNU General Public License v3.0
3.56k stars 104 forks source link

Implement key repeat for compositor bindings #345

Closed YaLTeR closed 2 months ago

YaLTeR commented 4 months ago

Discussed in https://github.com/YaLTeR/niri/discussions/344

YaLTeR commented 4 months ago

Apparently sway does key repeat for all bindings; GNOME does key repeat at least for custom spawn bindings. So it's probably worth to do key repeat for everything by default and have a flag to disable it?

salman-farooq-sh commented 4 months ago

I think no key-repeat makes sense more of the times than key-repeat does. What are the bindings which one would preferably want to have repeat enabled on? This is without thinking much but I can only think of volume and brightness relative adjustments. Most other binds are for stuff like launch an app, run a command, etc. which I think don't need repeats.

Really, I don't have any preference for the default of binding key-repeat enabled/disabled. Either way will be good.

And, thank you so much for the awesome compositor. I have been dailying it since this weekend for backend and frontend web-development and it is working really nicely especially with multi-monitors. Touchpad gestures and the animations are really nice and it is obvious considerable work went into properly tuning them.

salman-farooq-sh commented 4 months ago

I guess some people would like to have Mod+H/J/K/L etc. (in the default config) to repeat too when held.

YaLTeR commented 4 months ago

I think it's pretty standard to have repeat for changing focus and stuff (which is a lot of the commands), then for spawning GNOME seems to also do it, so why not.

YaLTeR commented 2 months ago

This is now implemented.