search

YaLTeR / niri

A scrollable-tiling Wayland compositor.
https://matrix.to/#/#niri:matrix.org
GNU General Public License v3.0
2.82k stars 79 forks source link

fix monitor reactivation for broken monitor firmware #488

Closed it-a-me closed 3 days ago

it-a-me commented 4 days ago

My monitor has a bug that causes it to be briefly re-detected as a new monitor while turning off. This allows power-off-monitors to work as intended. Powering on monitors causes a redraw so I don't believe this should cause any issues, but I'm open to advice about other ways I could attempt to fix this.

YaLTeR commented 4 days ago

Could you check if GNOME Shell keeps monitors powered off for you or also powers them back on right away?

it-a-me commented 4 days ago

It looks line gnome powers them right back on. I'm not all that familiar with it, but when I run busctl --user set-property org.gnome.Mutter.DisplayConfig /org/ gnome/Mutter/DisplayConfig org.gnome.Mutter.DisplayConfig PowerSaveMode i 1 gnome exhibits the same behavior of pre-patch niri where the display starts to turn off, then flickers back on.

YaLTeR commented 3 days ago

Upon closer inspection, I don't think the reset call is needed, so I removed it. Seems to work for me; do you mind testing once more? Then we can merge.

it-a-me commented 3 days ago

The new version works great. Thanks for the help

YaLTeR commented 3 days ago

Thanks!

edwrap commented 2 days ago

Thanks for this, solves the issue for my HP Omen monitor as well!