YaLTeR / niri

A scrollable-tiling Wayland compositor.
https://matrix.to/#/#niri:matrix.org
GNU General Public License v3.0
3.58k stars 105 forks source link

With `gaps 0` the focus ring is cut off #501

Closed Schweber closed 3 months ago

Schweber commented 3 months ago

When i set

layout { 
    gaps 0
    focus-ring {
        width 1
        }
}

the focus ring is cut off at the screen edges. I find this counter intuitive and would like the focus ring to always be visible all around the window. I expect gaps to specify a gap on top of the focus ring and not on top of the bare window without the focus ring.

System Information

YaLTeR commented 3 months ago

I mean, the focus ring goes around the window. If the window is flush with the edges, it will be cut off. You could use a border if you'd like something that is "included" into the window. Or as you mention, just set gaps to 1 manually (or left/right/top/bottom strut).

Schweber commented 3 months ago

You can of course keep the present behaviour as it's obviously intended by you but all tiling window managers that i know behave differently. I thus think that the common expectation would be that the focus ring is always visible.

YaLTeR commented 3 months ago

Do they have focus rings or is it a border?

Schweber commented 3 months ago

Oh sorry, i misunderstood what the focus ring is meant to do. I just read through the explaination in config.kdl again and saw that i don't need to use it and can just use regular borders with different colors as i'm used to.

I still would not have expected the focus ring to be invisible if no gaps are set though.

YaLTeR commented 3 months ago

Maybe it should render on top of other windows? Not sure

Schweber commented 3 months ago

I guess that people would complain about that as well, especially when the width of the focus ring is set to a large value.

YaLTeR commented 2 months ago

I just checked, the focus ring does already render on top of other windows, as it should. Which doesn't change the fact that it's cut off on the sides with no gaps (or struts), but yeah