search

YaLTeR / wl-clipboard-rs

A safe Rust crate for working with the Wayland clipboard.
Apache License 2.0
240 stars 17 forks source link

Remove failure dependency #24

Closed piegamesde closed 2 years ago

piegamesde commented 2 years ago

The crate is deprecated and abandoned. It suggests using thiserror as a replacement for the derive macros, but we already have derive_more which can do the same, so use that instead. This very likely is an API breaking change.

I apologize for making this change right after a new version was released. I should have payed more attention and made this PR before asking for a release.

YaLTeR commented 2 years ago

Well, looks like Travis has finally stopped working.

YaLTeR commented 2 years ago

I switched to GitHub Actions; please rebase to latest master so we could get the CI result.

YaLTeR commented 2 years ago

I see the tools also use failure; could you convert them too please?

piegamesde commented 2 years ago

Sure. Do you prefer eyre or anyhow as a replacement?

YaLTeR commented 2 years ago

Let's go with anyhow.

piegamesde commented 2 years ago

It compiles, please test it. I did not find a suitable replacement for exitfailure (I'm pretty sure some exists, but I couldn't find it).

YaLTeR commented 2 years ago

I did not find a suitable replacement for exitfailure (I'm pretty sure some exists, but I couldn't find it).

I think the suitable replacement nowadays is just returning Result<(), Error> from main.

YaLTeR commented 2 years ago

Thanks! Seems to work fine.