vcpkg broken

[matt328]

Something seems broken with the latest version (3.0.1) in vcpkg:

Building vulkan-memory-allocator-hpp[core]:x64-osx...
-- Downloading https://github.com/YaaZ/VulkanMemoryAllocator-Hpp/archive/v3.0.1.tar.gz -> YaaZ-VulkanMemoryAllocator-Hpp-v3.0.1.tar.gz...
[DEBUG] To include the environment variables in debug output, pass --debug-env
[DEBUG] Trying to load bundleconfig from /Users/matt/Projects/cpp/triton-cmake/vcpkg/vcpkg-bundle.json
[DEBUG] Failed to open: /Users/matt/Projects/cpp/triton-cmake/vcpkg/vcpkg-bundle.json
[DEBUG] Bundle config: readonly=false, usegitregistry=false, embeddedsha=nullopt, deployment=Git, vsversion=nullopt
[DEBUG] Metrics enabled.
[DEBUG] Feature flag 'binarycaching' unset
[DEBUG] Feature flag 'compilertracking' unset
[DEBUG] Feature flag 'registries' unset
[DEBUG] Feature flag 'versions' unset
[DEBUG] 1000: popen( curl --fail -L https://github.com/YaaZ/VulkanMemoryAllocator-Hpp/archive/v3.0.1.tar.gz --create-dirs --output /Users/matt/Projects/cpp/triton-cmake/vcpkg/downloads/YaaZ-VulkanMemoryAllocator-Hpp-v3.0.1.tar.gz.72196.part 2>&1)
[DEBUG] 1000: cmd_execute_and_stream_data() returned 0 after   421535 us
[DEBUG] Trying to hash /Users/matt/Projects/cpp/triton-cmake/vcpkg/downloads/YaaZ-VulkanMemoryAllocator-Hpp-v3.0.1.tar.gz.72196.part
[DEBUG] /Users/matt/Projects/cpp/triton-cmake/vcpkg/downloads/YaaZ-VulkanMemoryAllocator-Hpp-v3.0.1.tar.gz.72196.part has hash f15cfd5f7e74f0ddf821799cbdd45c3cdbe9cb07dff198ae35accb8f9890258a56856b9a1add5f0dd432b954ac5420c5e6e1da3ba725d9d1eb372d0589d8826e
error: Failed to download from mirror set
error: File does not have the expected hash:
url: https://github.com/YaaZ/VulkanMemoryAllocator-Hpp/archive/v3.0.1.tar.gz
File: /Users/matt/Projects/cpp/triton-cmake/vcpkg/downloads/YaaZ-VulkanMemoryAllocator-Hpp-v3.0.1.tar.gz.72196.part
Expected hash: 0631319ec892161acb85903ddeecf0b18ff6772fdb44b46c756f6c148d150ea0850f7a35f105a04e9b23baf6ea5aa9bb373e04c7be598f1caa23c22cacf4ee00
Actual hash: f15cfd5f7e74f0ddf821799cbdd45c3cdbe9cb07dff198ae35accb8f9890258a56856b9a1add5f0dd432b954ac5420c5e6e1da3ba725d9d1eb372d0589d8826e
[DEBUG] /Users/runner/work/1/s/src/vcpkg/base/downloads.cpp(960):
[DEBUG] Time in subprocesses: 421535us
[DEBUG] Time in parsing JSON: 14us
[DEBUG] Time in JSON reader: 0us
[DEBUG] Time in filesystem: 168us
[DEBUG] Time in loading ports: 0us
[DEBUG] Exiting after 424.114623 ms (422681us)

This

[DEBUG] 1000: popen( curl --fail -L https://github.com/YaaZ/VulkanMemoryAllocator-Hpp/archive/v3.0.1.tar.gz --create-dirs --output /Users/matt/Projects/cpp/triton-cmake/vcpkg/downloads/YaaZ-VulkanMemoryAllocator-Hpp-v3.0.1.tar.gz.72196.part 2>&1)

seems particularly wrong, why is it curl-ing this to a .72196.part file. I believe the filename being unexpected is throwing off the checksum since if I rename that file, it isn't corrupted or anything.

It's not a huge deal, I can vendor this lib pretty easily, but it would be the only one in all of my projects that doesn't play nice with vcpkg.

[McFlyboy]

Hi. There was an update to this repo a few days ago, but the new release seem to have replaced the old one @YaaZ ?

[YaaZ]

Oh I didn't know vcpkg downloads directly from Github, sorry. I pushed new v3.0.1 tag, that's why there's a hash mismatch. I'm gonna revert this and push updated version separately.

[YaaZ]

I restored v3.0.1 tag to the original commit, now it should work again, check this out please @matt328 @McFlyboy

[YaaZ]

Also, new tag for VMA 3.0.1 compatible with fresh Vulkan-Hp - v3.0.1-1

[McFlyboy]

No worries @YaaZ. I see the new tag in Releases, but I don't see the original v3.0.1. Was it properly restored?

[YaaZ]

@McFlyboy there're now v3.0.1 and v3.0.1-1 tags, see https://github.com/YaaZ/VulkanMemoryAllocator-Hpp/tags I updated the release to point to the new tag, but that shouldn't be a problem for vcpkg, as it downloads the revision by tag, not by release (according to logs).

[matt328]

Everything looks good over here now, thanks!

[McFlyboy]

Aah ok. Thanks for the help @YaaZ :)

[McFlyboy]

Btw @matt328, v3.0.1 only works with Vulkan SDK up towards version 1.3.231.1. Any newer version has to be used with v3.0.1-1 which isn't available in vcpkg yet. I'm gonna update the port