Closed saschasc closed 2 years ago
Hey @saschasc! I'm pretty sure you should be getting such warnings not only from VMA-Hpp, but from Vulkan-Hpp too, aren't you?
These warnings make sense indeed, as there's no point in comparison of pointers&structs etc other than for equality, so I guess it would be okay to replace operator<=> = default
with operator== = default
...
Buuuut I'm trying to stick close to the Vulkan-Hpp which has the same explicitly defaulted <=> operator for structs, that's why I'm asking whether you're getting the same warnings there. Then we can probably try PRing Vulkan-Hpp and update VMA-Hpp too.
Waiting for an answer: https://github.com/KhronosGroup/Vulkan-Hpp/issues/1315
In the meantime you can try the dev
branch
Currently, when upgrading to Vulkan SDK 1.3.211.0 I only have the warnings from VMA-Hpp. But I would have to look again into it. I was able to compile the whole project by fixing it only in VMA-Hpp.
I understand that you want to stick close to the Vulkan-Hpp project. This makes absolute sense for me, too.
Let's see what answer we will get :-)
Thanks!
Interestingly, I tested it with the same Clang and Vulkan-Hpp version and I got the same warnings from Vulkan-Hpp too.
I have only recently changed to C++ 20 and therefore still had a define VULKAN_HPP_NO_CONSTRUCTORS activated. Then it did not compile. By removing this define it works with your changes from the dev
branch.
@YaaZ Great that you continue this project. When compiling with clang 13.0.1 I get several warnings regarding the three-way comparison operator and user-declared copy assignment operator.
Tested with Vulkan SDK 1.3.211.0.