search

YabataDesign / afterglow-theme

[DEPRECATED] A minimal dark Theme for Sublime Text 2 and 3
http://yabatadesign.github.io/afterglow-theme/
2.12k stars 139 forks source link

JSON highlighting #41

Open jbrooksuk opened 9 years ago

jbrooksuk commented 9 years ago

I'm using Afterglow-monokai colour scheme but there is no JSON highlighting.

mknabe commented 9 years ago

@jbrooksuk I think that is intentional. The default sublime text monokai color scheme, on which the Afterglow-monokai scheme is based, has white text for JSON files.

bmcminn commented 8 years ago

I think the bigger issue here is that the NPM JSON file type that gets applied causes the syntax highlighting to break. JSON configs elsewhere are highlighted just fine.

The silly part is I have to configure JSON highlighting in two separate syntax configs because of JSON vs NPM JSON.

{
    "extensions":
    [
        "json"
    ],
    "color_scheme": "Packages/Theme - Afterglow/Afterglow.tmTheme"
}
mknabe commented 8 years ago

@bmcminn have you tried setting JSON as the fallback syntax for NPM JSON? See this merge commit for an example

https://github.com/YabataDesign/afterglow-theme/pull/95/commits/9f83ec59f5482b1775f6e4746fe58557cb18d630

bmcminn commented 8 years ago

I really think we need to fork this repo indefinitely under a new org or something, because it's apparent @YabataDesign has no interest in pulling in features and updates.

That or @YabataDesign needs to create the org and invite a few contributors to help manage the PR's and community that has built around this theme.