search

YabataDesign / afterglow-theme

[DEPRECATED] A minimal dark Theme for Sublime Text 2 and 3
http://yabatadesign.github.io/afterglow-theme/
2.11k stars 138 forks source link

Folder plus/minus Missing #85

Closed bbeckford closed 9 years ago

bbeckford commented 9 years ago

After the package updated sometime over the weekend the plus/minus icons on folders in the side bar have disappeared.

Using Sublime 2.0.2 Build 2221

Example of no folder plus/minus

TheFox commented 9 years ago

Same here. This is since Afterglow v2.1.1.

The sidebar icons even don't appeared in version 2.1.0. I don't have "sidebar_no_icon": true in my user settings but there where no icons. Even if I turn it to false there are no icons. How can I add the sidebar icons?

How can I jump back to Afterglow v2.1.0 with Package Control?

bbeckford commented 9 years ago

Replacing Afterglow-blue.sublime-theme with the previous version does repair the issue so it's definitely something introduced in the last commit.

I'd create a pull request by my knowledge of sublime theming is pretty limited!

Thanks

TheFox commented 9 years ago

Replacing Afterglow-blue.sublime-theme with the previous version does repair the issue

Unfortunately not. I tried it too.

bwlt commented 9 years ago

I see that many lines removed on pull request #83 are relatives to theme sections:

from commit tagged 2.1.0 (not included) to origin/HEAD all the +/- icons are not displayed :( (tested on subl2)

bbeckford commented 9 years ago

Unfortunately not. I tried it too.

  • TheFox

That's strange, it worked for me. Are you using the blue theme? If not did you try with the right theme colour file?

TheFox commented 9 years ago

No, I tried it with default theme on Sublime Text 2. Yes, I used the right theme color file.

jpark1120 commented 9 years ago

I am having the same issue on sublime text 2 (v2.0.2, Build 2221) after package updated.

pajenkin commented 9 years ago

I am having the same issue. I am working with Sublime Text 2 (v2.0.2, Build 2221).

Rutger commented 9 years ago

My latest commit (#83) causes this.

I didn't know the sidebar icons were missing in Sublime Text 2, and my solution to issues #82 and #79 was to change the expand-button to the space where the icons would be in.

Knowing this, the poor alignment issues turn out to be really hard to fix without removing the icons.

I would like to ask @YabataDesign to revert the changes until we find a solution that works for everyone. Apologies.

gin93r commented 9 years ago

I have also experienced this with ST2.

extractachris commented 9 years ago

+1. ST2.