Yadoms / yadoms

Yadoms is open source, simple, powerfull, flexible and multiplatforms domotic solution.
https://www.yadoms.com
Other
63 stars 17 forks source link

AsyncSerialPort blocking #283

Closed jano42 closed 6 years ago

jano42 commented 7 years ago

When the plugin RfPlayer starts without the dongle connected, it tries to send packet on port.

But in the end (AsyncSerialPort is used) and is blocked. line 220

As there is nothing connected, the function never returns, so the plugin is blocked. (unable to stop it,...)

image

I've seen this bug by trying to solve #282

The issue can be reproduced easily, by adding the plugin RfPlayer, by selected a not connected serial port.

The function should at least throw a timeouut exception....

sgallou commented 7 years ago

It's probably caused by using flow control. We have to set up timeouts.