Yaffle / EventSource

a polyfill for http://www.w3.org/TR/eventsource/
MIT License
2.11k stars 338 forks source link

Is this still a polyfill? #207

Closed xsrvmy closed 2 years ago

xsrvmy commented 2 years ago

Definition of polyfill by Mozilla: "A polyfill is a piece of code (usually JavaScript on the Web) used to provide modern functionality on older browsers that do not natively support it."

When you add code doing more than what the modern actually API does, it is no longer really a polyfill.

199 #205

TheOtterlord commented 2 years ago

Very true. No matter someones views on malware/protestware and whether this fits the definition, this is definitely no longer a polyfill and shouldn't be used as one.

Yaffle commented 2 years ago

Please change the definition so

TheOtterlord commented 2 years ago

Change the definition of polyfill to include unexpected, undocumented behavior?