activation...

[Alireza-Ghavabesh]

Hi thank you for building library...

when I click on update in plugins page it will be update but showing Update failed and a json like this:

{"success":true,"data":{"update":"plugin","slug":"unique-plugin-or-theme-slug","oldVersion":"\u0646\u06af\u0627\u0631\u0634 1.0.0","newVersion":"\u0646\u06af\u0627\u0631\u0634"}

I think most things seem to be true because of "success":true,"data" !

I would also like to say that after Update failed my old version plugin Successfully replaced.

Now what i have to do for fix Update failed to Update Successfully ???

[YahnisElsts]

Some ideas:

• Is there anything else in the JSON response, like any unexpected newlines or PHP notices/errors? That can sometimes prevent WordPress from parsing the JSON and make it say that the update failed even though it was actually successful.
• Some time ago, there was a WordPress bug where AJAX updates wouldn't work properly for plugins that had a mix of lowercase and uppercase characters in the plugin folder name (e.g. Example-Plugin). If your plugin has something like that, try changing the folder name to lowercase.
• It looks like there are some non-Latin characters in the version numbers. I'm not sure how well WordPress handles different languages in version numbers. To check if it's a compatibility issue, try using a version number that only contains digits, periods, and Latin (English) letters.

[geoffthibeau]

The third parameter of Puc_v4_Factory::buildUpdateChecker should be the theme or plugin slug. Your example response above is using the example slug unique-plugin-or-theme-slug.

If you changed the JSON response in the issue to obfuscate your actual slug, that's fine. But I wanted to call out the possibility of a mismatch if you didn't update the your code to pull your specific slug.

[Alireza-Ghavabesh]

thank you very much, my problem fixed

My problem was that the name of the new plugin was not equal to the third parameter