search

YahnisElsts / plugin-update-checker

A custom update checker for WordPress plugins. Useful if you don't want to host your project in the official WP repository, but would still like it to support automatic updates. Despite the name, it also works with themes.
MIT License
2.25k stars 410 forks source link

Use plugin screenshots from the local "assets" directory. #463

Open timwiel opened 3 years ago

timwiel commented 3 years ago

Just like the icons and banners we can use screenshots from the assets directory

However the implmention needs to be slightly different as the screenshot captions are extracted from the readme.txt file and the screenshot files from the assets directory.

WP Standards taken from

YahnisElsts commented 3 years ago

That doesn't seem like the best idea. It looks like it combines the screenshots from the currently installed version with screenshot descriptions from the latest version. There's no guarantee that these things will match up correctly. Also, the screenshots would be shown in the "view details" pop-up, which is supposed to show information about the latest version, not about the installed version.

Using the locally stored icons and banners is probably fine because those parts of the plugin are very unlikely to change between versions. However, screenshots might not always stay the same. I think that if you want to show them, you would really have to retrieve them from the repository somehow. I'm not sure how feasible that is - for example, some hosts might have issues with hotlinking images from private repositories.