Github assets issue (+ fix in PR)

YahnisElsts / plugin-update-checker

A custom update checker for WordPress plugins. Useful if you don't want to host your project in the official WP repository, but would still like it to support automatic updates. Despite the name, it also works with themes.

MIT License

2.22k stars 403 forks source link

Github assets issue (+ fix in PR) #514

Closed liedekef closed 1 year ago

liedekef commented 1 year ago

I created a PR #513 to fix issues with gihub and assets :

in GitHubApi.php: array_filter keeps the index, so if the asset matching has index 1, an array with key 1 is returned. However, further down, $matchingAssets[0] is always used. This will then fail. Using array_values after array_filter resets the indexes on the array from 0, solving the problem.
When setting "$myUpdateChecker->setBranch('main');" the setting enableReleaseAssets was ignored. But since on newer github repos "main" is the default (and not "master"), it should allow it (even though it is ok to omit it).

YahnisElsts commented 1 year ago

Good catch on the array index issue.

Regarding the main branch: I think the way PUC currently handles default branches and associated releases is sub-optimal, but I don't feel like rewriting that logic at this time. I'll merge the change.

Ideally, enabling release assets should probably enable releases regardless of the selected branch. Also, the existing vcs_update_detection_strategies filter should provide an easier way to enable specific strategies, maybe with something like an $availableStrategies argument.

liedekef commented 1 year ago

Well, when enabling release assets one just doesn't need to mention the branch and then all works ok :-) Thanks for the merge.