search

YahnisElsts / plugin-update-checker

A custom update checker for WordPress plugins. Useful if you don't want to host your project in the official WP repository, but would still like it to support automatic updates. Despite the name, it also works with themes.
MIT License
2.27k stars 411 forks source link

Fix EC violations #548

Closed szepeviktor closed 10 months ago

szepeviktor commented 1 year ago

All stray spaces are gone! I've changed insert_final_newline to true. Tool to check: https://github.com/greut/eclint JSON files went from TAB-s to spaces. I hope it is okay for you.

Review without whitespace changes: https://github.com/YahnisElsts/plugin-update-checker/pull/548/files?diff=unified&w=1

YahnisElsts commented 10 months ago

Seems low priority, and I still haven't found the will to go through it and review everything, so I'm going to err on the side of "don't fix it if it's not (too) broken".

szepeviktor commented 10 months ago

All right. I've never met anyone having time to care about each and every byte.

The review is a breeze! https://github.com/YahnisElsts/plugin-update-checker/pull/548/files?diff=unified&w=1