search

YahnisElsts / plugin-update-checker

A custom update checker for WordPress plugins. Useful if you don't want to host your project in the official WP repository, but would still like it to support automatic updates. Despite the name, it also works with themes.
MIT License
2.26k stars 411 forks source link

Github Updates Not Authenticating from Private Repository #84

Closed prowp closed 7 years ago

prowp commented 7 years ago

Thank you for your recent work on this. I'm trying to set up a theme for automatic updating and when trying to pull from github, the access token is not getting appended to the url.

Reading through the code, I think the githubapi file is missing it's own version of signDownloadUrl possibly. If I append $this->accessToken to the url manually it works fine, but there is something not quite right is the routine.

YahnisElsts commented 7 years ago

Thank you for the report. It looks like you're right - that part of the authentication code got lost in the 4.0 overhaul.

Try the master branch - the bug should be fixed there.

prowp commented 7 years ago

Thank you! Please let me know if you are taking donations anywhere for the work on this repository.

YahnisElsts commented 7 years ago

Sure, no problem.

I don't take donations at the moment.