search

YahooArchive / arrow

FE Test framework designed to promote TDD
http://yahoo.github.io/arrow/arrow_intro.html
BSD 3-Clause "New" or "Revised" License
55 stars 59 forks source link

Remove "path.existsSync is now called `fs.existsSync`." terminal output #119

Closed jamsyoung closed 11 years ago

jamsyoung commented 11 years ago

When existsSync is declared in some places it checks for fs.existsSync first, defaulting to path.existsSync when not found. In other places this is reversed. In the cases where path.existsSync is checked for first, newer versions of node will output a message to the terminal that path.existsSync is now fs.existsSync. Reversing the order in these three files gets the declaration consistent with the rest of the code base that already does this, and prevents that message from being output to the terminal.

Ran npm test, all test are still passing.

Final summary: Passed: 266, Failed: 0, Skipped: 6, Total: 272, Load errors: 0, Statement coverage: 79.79%, Branch coverage: 66.24%, Function coverage: 85.95%, Line coverage: 80.32%

proverma commented 11 years ago

This is already part of PR #115 , closing this PR for now. Thanks for working on it.