search

YahooArchive / arrow

FE Test framework designed to promote TDD
http://yahoo.github.io/arrow/arrow_intro.html
BSD 3-Clause "New" or "Revised" License
55 stars 59 forks source link

Lock YUI dependency to version 3.6.x #2

Closed mridgway closed 12 years ago

mridgway commented 12 years ago

Arrow does not seem to work with YUI 3.5 ("YUITest is not defined" in yuitest-runner.js) so it should be locked down to the 3.6 versions.

proverma commented 12 years ago

I am not sure if its just YUI 3.5 or something else, I am still working on that error, but we inject the npm YUI object only when YUI object is not found on that page, However the error you mentioned happens mostly on pages which already had some version of YUI. Hence I dont think version locking would have much impact on it....Also Doesn't "*" always gets the latest YUI version ( currently v3.6.0 ) ?

Thoughts ?

mridgway commented 12 years ago

I think you're right. When I first encountered this it was when I was using Arrow as a dependency from Mojito. Mojito already had YUI 3.5.1 as a dependency, so Arrow did not re-install YUI and thus used 3.5 instead of 3.6. Since then, I haven't actually run into this error though and Travis didn't either.

Closing since I can't reproduce it consistently anymore.

mridgway commented 12 years ago

Reopening based on issue #10.

travisbot commented 12 years ago

This pull request passes (merged 1f4efc3e into 23b70ba1).