search

YahooArchive / arrow

FE Test framework designed to promote TDD
http://yahoo.github.io/arrow/arrow_intro.html
BSD 3-Clause "New" or "Revised" License
55 stars 59 forks source link

Make YUI a peerDependency #221

Closed redonkulus closed 10 years ago

redonkulus commented 10 years ago

This allows applications to determine which YUI version is used with Arrow. If they do not specify YUI, then Arrow will use the latest stable.

@pranavparikh

pranavparikh commented 10 years ago

@redonkulus I tried this with my branch - https://github.com/pranavparikh/arrow/tree/yuiPeerDep

The unit test job is failing - https://travis-ci.org/pranavparikh/arrow/jobs/23096707 Need to debug more.

akshayp commented 10 years ago

@pranavparikh Any updates here? The builds looks like it's passing now

pranavparikh commented 10 years ago

@akshayp @redonkulus

I'm testing this out here - https://github.com/pranavparikh/arrow/tree/yuiPeerDep

I had to add yui as devDependency as Arrow uses ytestrunner (which needs yui) for running unit tests. Else the build fails - https://travis-ci.org/pranavparikh/arrow/jobs/24354378

Not sure if its a correct approach.Do you know of any other solution ?

Here's the test project https://github.com/pranavparikh/myTestProject

proverma commented 10 years ago

closing this as we are tracking it on #242