Arrow should retry starting PhantomJS when it crashes

YahooArchive / arrow

FE Test framework designed to promote TDD

http://yahoo.github.io/arrow/arrow_intro.html

BSD 3-Clause "New" or "Revised" License

55 stars 59 forks source link

Arrow should retry starting PhantomJS when it crashes #240

Closed ericedem closed 10 years ago

ericedem commented 10 years ago

For some reason, in our build environment, phantomjs has started failing randomly. Arrow should attempt to retry starting phantomjs, but instead it fails on the first standard error message. Here is the relevant line of code

https://github.com/yahoo/arrow/blob/master/lib/util/phantomJsSetup.js#L54

ericedem commented 10 years ago

On further investigation, it looks like phantomjs is crashing later on, and the message we see is because the handler happens to still be attached.

pranavparikh commented 10 years ago

Fixed with https://github.com/yahoo/arrow/pull/243