Using --browser setting will no longer automatically use selenium driver

YahooArchive / arrow

FE Test framework designed to promote TDD

http://yahoo.github.io/arrow/arrow_intro.html

BSD 3-Clause "New" or "Revised" License

55 stars 59 forks source link

Using --browser setting will no longer automatically use selenium driver #3

Closed mridgway closed 12 years ago

mridgway commented 12 years ago

This is important so that you can run descriptors that contain both selenium and nodejs tests. Without this change you are restricted to firefox browsers for mixed driver runs. I think this may be the cause for the race conditions I was seeing when running Mojito's tests (reported internally).

proverma commented 12 years ago

As discussed on other thread, seems like passing "driver=nodejs" for your test atoms is working fine for you. I am closing this pull request, do let me know if you have more ideas on this topic.

mridgway commented 12 years ago

That does solve our problem, but I still find it odd that running arrow test_descriptor.json will use an automatic rationalization of the driver and then use Firefox, but there is no way to use the automatic rationalization with another browser. To me, using arrow test-descriptor.json --browser=phantomjs shouldn't change the driver setting as it does now.