Fixes a bug attaching beacon URL parameters

YahooArchive / boomerang

End user oriented web performance testing and beaconing

http://lognormal.github.com/boomerang/doc/

Other

1.18k stars 447 forks source link

Fixes a bug attaching beacon URL parameters #37

Closed edgarklein closed 12 years ago

edgarklein commented 12 years ago

When attaching beacon URL parameters boomerang always starts attaching the parameters with "?". This is incorrect if the beacon URL already contains URL parameters. This fix checks whether the URL contains a "?" and if it does, it will attach the parameters prefixed with "&".

bluesmoon commented 12 years ago

agreed, this should be merged in.

bluesmoon commented 12 years ago

merged into bluesmoon/master with a few mods, and have requested an upstream pull.

edgarklein commented 12 years ago

I hope you merged all 3 pull requests because they are all related.

bluesmoon commented 12 years ago

yeah, that's the way git rolls ;)