Vars in boomr being checked against boomr itself

YahooArchive / boomerang

End user oriented web performance testing and beaconing

http://lognormal.github.com/boomerang/doc/

Other

1.18k stars 448 forks source link

Vars in boomr being checked against boomr itself #8

Closed kalyan02 closed 13 years ago

kalyan02 commented 13 years ago

Fixed this. Vars in boomr are checked against BOOMR and copied if BOOMR doesn't have them.

bluesmoon commented 13 years ago

I don't think this is correct. Everything from boomr must be written into BOOMR even if it overwrites what's already in BOOMR. The only thing that can be written to BOOMR before boomerang.js loads is plugins and those are preserved.

A second problem with this patch is that if some code were to override Object.prototype, then it has the unfortunate side effect of adding all those prototype properties to the BOOMR object.