search

YahooArchive / coname

An experimental cooperative keyserver based on ideas from dename.
Apache License 2.0
107 stars 20 forks source link

gogoproto protobuf jsonification #50

Open andres-erbsen opened 8 years ago

andres-erbsen commented 8 years ago

The JSON marshalers and unmarshalers our generate script produces using the latest gogoproto do not pass the autogenerated tests (they fail by trying to unmarshal an enum as if it had been encoded as an int, but it is actually encoded as a string). I don't know what causes this.

OTOH, the only part where andres-erbsen/protobuf differs from gogo/protobuf is the jsonpb package. In particular, I believe this means that we do not need to use my fork for code generation, only for json marshaling (by sed-patching the jsonpb in the generated files). This will hopefully let us catch the next issue of this kind right when gogoproto introduces it. Even better, if we play it well, then we might be able to upstream the jsonification patch ("prefer specialized Marshal/Unmarshal implementations to the generic" can sound pretty well, even though we use this in a hacky way in our project).

How urgent is updating gogoproto compared to working on cluster membership changes?

maditya commented 8 years ago

This can very well happen after the cluster membership changes.