Closed diracdeltas closed 9 years ago
CLA is valid!
For reference, the merge that caused verification to break in the extension was https://github.com/square/go-jose/pull/20.
LGTM. Thanks for the detailed catch.
Please note the request in my pull request:
Do not merge yet; haven't checked that tests still pass with this change.
they in fact don't pass, but it's a trivial change so i'll do it now.
The JOSE implementation that we're using for the keyserver recently changed the default JWS header. Checking the parsed header for expected parameters is less fragile than checking the header string against expected values.
Do not merge yet; haven't checked that tests still pass with this change.